-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update MIPS toolchain version #76
Conversation
@kaspar030 do we need to do this if there are plans to remove mips RIOT-OS/RIOT#11788. Otherwise, I was able to build the image but I have no hardware to test it. |
Could you provide some kind of test output? |
2c7434b
to
a9ac74c
Compare
IMO that's just a suggestion. Removal of mips might happen later if it maintanance doesn't improve. |
Ok I re-read the discussion thread, there doesn't seem to be a clear agreement yet. |
Since I have no hardware to test |
We have a chicken and egg problem. The new toolchain from this PR fails on 2019.04. There's a fix in RIOT-OS/RIOT#11986. Anyhow, travis for this repo will (currently) always use 2019.04. Ideas? Maybe first switch to 2019.07, then merge #11986, then backport to 2019.07-release? |
Weren't we thinking about release specific tags for this repo anyways (#64)? |
I downloaded the MIPS toolchain 2018.09-03 using the link found in the Dockerfile. I did a clean build of RIOT PR #12227, including the diff I mentioned in this PR. The board was printing the correct message over UART. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested by @francois-berder
ACKing to get that out of the way for sorting out the merge order.
So if we trigger Murdock again, this should work now? |
a9ac74c
to
253057c
Compare
it should! |
Somehow this exact PR gets scheduled to a travis worker that seems to be hopelessly overloaded... |
😕 |
After unpacking, remove documentation and deduplicate identical binaries by using hardlinks to save space.
253057c
to
b3cf777
Compare
Now it went through! &go |
This upgrades the MIPS toolchain to the latest version.
Supercedes #47.